Links in comments get mangled when requesting an edit by a moderator.

Avatar
  • updated
  • Under review

Hi Daniel,


This is a bit involved, so bear with me. I have to give a little background info here first. The "edit comment" feature where I can fix my own typos within 15 minutes after submitting a comment is fantastic. I am prone to typos so I use this thing all the time. 


The "edit comment" feature does a great job even with comments containing links. As you are aware, hyperlinks in comments are turned into tiny URLs when the comment is submitted. The "edit comment" feature undoes the tiny URL and restores the full link when editing a comment. The link is then turned back into a tiny URL when the fixed comment is resubmitted. This allows me to fix words, sentences or entire paragraphs during the 15 minute grace period. Links are never mangled because tiny URLs are undone and redone seamlessly by "edit comment".


Unfortunately everything changes after the 15 minute grace period. At that point I must request a moderated edit to fix a typo. I understand the reason for requiring a moderator and have no issue with that. But there seems to be a problem with comments containing links. When I request a moderated edit for a comment containing a link, that link inevitably gets mangled. Most of time I simply want to fix a word or sentence and don't want any change to occur with the link. When I submit the edit request, the moderator faithfully fixes the word or sentence but all links are broken in the process. 


I'm not sure why this happens. Perhaps the editing tools used by moderators are not as versatile as the "edit comment" feature available during the 15 minute grace period. Maybe the tiny URLs are not properly undone prior to editing and properly turned back into tiny URLs afterwards. Maybe the links remain tiny URLs during the edit and then get hashed again into bogus tiny URLs. Maybe there is a character set incompatibility across disparate systems that screws up the rehashing of links. Don't really know for sure about the details, but the bottom line is those links get totally hosed by the moderated edit.


Submitting a plea of caution along with fully expanded references of all URLs will sometimes yield good results. But expanding the URLs and noting their placement in the comment is laborious and unrelated to the actual edit request. Most of the time only a word or a sentence requires correction and the links just need to be preserved. 


The additional complexity of specifying expanded URLs and their placement within the comment is unsatisfactory. Many times the request for caution goes unheeded. Words and sentences are properly edited but the links get broken anyways. Other times the links are preserved but the formatting gets messed up. I'm a bit of a stickler for details. Paragraphs should be properly delineated and each link should occupy a separate line. My use of linefeed is deliberate and not random. I also like double dashes and a space to precede links. Often times a short phrase in parenthesis immediately follows a link on the same line to describe it. Clarity of presentation goes hand in hand with clarity of thought.


All this stuff goes out the window if I request an edit of any comment containing a link. For a concrete example consider the comment linked below.


-- https://seekingalpha.com/article/4105564-massive-capital-needs-cause-fuelcell-energys-turn-toxic-financing#comment-76369037 (This comment has a typo)


This comment was submitted a few days ago by me. I discovered a typo after the 15 minute grace period and have been weighing the risks of having it fixed by a moderator. The typo is minor except for the fact the comment contains two links. The links are preceded by double dashes and space, followed by descriptions in parenthesis, and occupy deliberately chosen positions between paragraphs. In short, this is a moderated edit request minefield just waiting to get screwed up.


All I want done to this comment is have the word "buys" replaced by the word "picks". The edit is technically trivial but contextually important. Cummins picked Ceres for a partnership, they didn't buy Ceres. My phrase next to the link needs fixing. Everything else in the comment is fine and should remain unchanged.


I was about ready to write off this regrettable typo. But then I thought about the great job you did fixing a problem I reported on September 19th. Maybe you can help me again.


At a minimum, please fix my comment typo as requested. More generally, it would be great if you could find out why links get broken by moderated edits and fix that problem. Moderators should be able to fix typos as effortlessly and flawlessly as I can via "edit comment". That seems like a reasonable capability for moderators.


Appreciate your consideration in this matter. Let me know. Thanks.
Avatar
stocks for profit
Quote from stocks for profit

I've just verified that moderated edits with links have been fixed. Kudos.


Appreciate your effort. Thanks.

A lot has happened to moderated edits and "Edit Comment" over the last few months. I want to make a few observations for the record to establish a new baseline in case something breaks again.


"Edit Comment" works fine after the recent anomalies seen over the holidays. But the behavior has changed from October 2017 when my original request regarding moderated edits was submitted. Back then, clicking "Edit Comment" during the 15 minute grace period would expand short URLs or alias URLs back into full URLs in the edit box. Seeing the long URL was useful to identify links while editing. Upon updating, the long URLs would be converted back into short URLs or alias URLs. "Edit Comment" could be used repeatedly during the grace period and the URLs would convert back and forth between long and short/alias form without issue.


The new behavior with "Edit Comment" is as follows. Clicking "Edit Comment" during the 15 minute grace period does not expand short URLs or alias URLs back into their long form. Short URLs are left unchanged and alias URLs are shown in short form without alias in the edit box. Upon updating, short URLs stay unchanged and the previously aliased URLs are converted to new short URLs without alias. Subsequent use of "Edit Comment" during the grace period preserves short URLs without issue.


Moderated edits back in October 2017 would break links in comments. That was the reason for my original request. Fortunately that problem has been fixed now. Short URLs are preserved without issue. Interestingly, alias URLs are also preserved without issue or further conversion to non-alias short form. 


It is noteworthy that moderated edits preserve aliases while "Edit Comment" during the grace period converts all alias URLs into new short URLs. Apparently moderators have a different user interface to account for this alternate behavior. Inconsistent handling of data across different interfaces can sometimes be a source of problems. Fortunately this is not the case here.


Well, that's about it.  Hopefully we'll never have to revisit this subject.

Avatar
stocks for profit
Quote from stocks for profit

Wow, I thought your Jan 3 reply was related to the recent crazy stuff with "Edit Comment". That's what we've been discussing for the last 10 days. Since the alias, &, > bugs were still present on Jan 4, it looked broken to me. I thought you were fixing it based on my new feedback. Only today did I see that the alias, &, > bugs were fixed. 


I had no idea you also fixed moderated edits. When the heck did you fix that?


If it was awhile ago, you should have told me sooner. Spontaneous discovery by me was out of the question. There's no way I would have risked fixing a typo with a moderated edit if it also trashed the links. Not worth it.


Thanks for letting me know now. I'll have to check it out and get back to you.



I've just verified that moderated edits with links have been fixed. Kudos.


Appreciate your effort. Thanks.

Avatar
stocks for profit
Quote from anonymous

Hi,


This issue was fixed a while back. Have you had a recent incident with moderation where the links were broken?

Wow, I thought your Jan 3 reply was related to the recent crazy stuff with "Edit Comment". That's what we've been discussing for the last 10 days. Since the alias, &, > bugs were still present on Jan 4, it looked broken to me. I thought you were fixing it based on my new feedback. Only today did I see that the alias, &, > bugs were fixed. 


I had no idea you also fixed moderated edits. When the heck did you fix that?


If it was awhile ago, you should have told me sooner. Spontaneous discovery by me was out of the question. There's no way I would have risked fixing a typo with a moderated edit if it also trashed the links. Not worth it.


Thanks for letting me know now. I'll have to check it out and get back to you.



Avatar
anonymous

Hi,


This issue was fixed a while back. Have you had a recent incident with moderation where the links were broken?

Avatar
stocks for profit

Hi Daniel,


The recent bug with hyperlink aliases seems to be fixed. Also the & and > bugs are fixed too. Thanks.


P.S. - Please keep me posted on the status of my original request regarding the fix for moderated edits with links.

Avatar
stocks for profit

Daniel, here's a concise version...


"Edit Comment" mishandles hyperlink aliases. The alias clobbers the href value on update.


 < a href="URL location" > Alias < / a >


That's OK if alias defaults to the actual short URL. But a real alias, like an abbreviated URL with ellipsis, causes a problem.

Avatar
stocks for profit

Daniel, did you miss this? An excerpt from a long note I made yesterday here...


When clicking on "Edit Comment", all links are pulled into the edit box with their associated markup language as described in one of my earlier notes. The markup language shows each short URL twice, once with the href tag and again at the end for the display value. The href and display are the same for all links except the two with ellipsis. Those two have the actual short URL only in the href tag and show the abbreviated URL with ellipsis at the end of the markup.


Example of a non-abbreviated short URL with spaces added to suppress conversion:

< a rel="nofollow" target="_blank" href="http : // read . bi / 2xhXwpZ" >http : // read . bi / 2xhXwpZ 

< / a  >


Example of an abbreviated short URL with spaces added to suppress conversion:

< a rel="nofollow" target="_blank" href="http : // delonline . us / 2ecQSbo" > http : // delonline . us / 2e...

< / a >


So far so good. The href tag values for all links are fine, which is the actual definition for the hyperlink. The display values for the two abbreviated links should not be a problem either. But ending the edit and posting back reveals the problem. The two abbreviated links are now broken. All the other links are fine. Clicking "Edit Comment" again pulls the links back into the edit box.

 

Inspecting the markup language of one of the broken links reveals the following:

< a rel="nofollow" target="_blank" href="http : // delonline . us / 2e" > http : // delonline . us / 2e< / a >...


The link display value has become the definition for the hyperlink in the href tag. The ellipsis is no longer part of the markup text and now appears outside the delimiters. Clearly the abbreviated short URLs are mishandled by "Edit Comment". 


That is the problem.

Avatar
stocks for profit
Quote from anonymous

This issue should now be fixed. Please let us know.


Thanks!

It's still broken. I'm creating test comments at the link below...


https://seekingalpha.com/filing/3803278#comment-77204377


Ampersand and right angle bracket are still a problem. Links are also problematic. Look at my new notes above about links. Forgive the evolutionary development of ideas. It was all stream of consciousness. Start at the beginning and read through it. 


As a side note, I liked the old behavior where the original long form URL was restored by "Edit Comment". I'm not sure the new "Edit Comment" behavior for links is desirable even if you can fix it. Showing HTML markup language is a little technical. Consider that the target audience are investors and most of them are not HTML savvy. The only benefit I see is the ability to hide the actual hyperlink behind a more friendly description. But clearly that doesn't work right now and is actually causing the problem.


From the larger perspective of my original request for fixing moderated edits, we seem to be stepping backwards. Unless of course you think the bug we're trying to fix now is somehow related to the problem with moderated edits. Hopefully one step back will be followed by two steps forward. 


What is causing these recent anomalies with "Edit Comment"?  Let me know.

Avatar
stocks for profit
Quote from stocks for profit

"I remember seeing other kinds of links..."


Quickly scanning the past 6 months of my comments reveals this list of short URL variants. The ones below are only a small sample of what clearly must be a huge variety of short URLs. The exception handling I mention in my previous note must be general enough to cope with this.


seekingalpha . com / c / aaaaaa
bit . ly / aaaaaaa
tinyurl . com / aaaaaaaa
lat . ms / aaaaaaa
reut . rs / aaaaaaa
on . app . com / aaaaaaa
read . bi / aaaaaaa
for . tn / aaaaaaa
cnb . cx / aaaaaaa
delonline . us / aaaaaaa
on . ny . gov / aaaaaaa


Anything longer than 14 characters is probably getting screwed up by "Edit Comment" right now. Well, I'm not going to tell grandma how to knit. I just want a nice fitting sweater. All the best to you.


There's no substitute for testing. 


Here are 10 long URLs taken from actual comments I've made over the last 6 months. They generated 10 short URLs which are the variants I describe in my previous note. I tried to include an example from the past which convert into a tinyurl . com example, but those full links seem to turn always into bit . ly short URLs now.


These 10 long URLs shown below become short URLs when posted in a comment. Each one generates a different variant of short URL. 


SA comment
-- https://seekingalpha.com/article/4131713-fuelcell-arrives-port-long-beach#comment-77229139

bit . ly
-- https://www.utilitydive.com/news/new-york-expected-to-set-high-bar-for-energy-storage-after-target-bill-pass/445845/

lat . ms
-- http://www.latimes.com/me-2003-los-angeles-streetcar-history-story.html

reut . rs
-- https://www.reuters.com/article/us-singapore-exxon-plant/exxonmobil-opens-third-cogeneration-power-plant-in-singapore-idUSKBN1CH07O

on . app . com
-- http://www.app.com/story/money/business/main-street/2017/09/08/vonage-ceo-fake-news/634939001/

read . bi
-- http://markets.businessinsider.com/news/stocks/FuelCell-Energy-Announces-20-Megawatt-Fuel-Cell-Project-with-Korea-Southern-Power-CompanyRepresents-first-fuel-cell-project-for-Korea-Southern-Power-Company-KOSPO-1002313440

for . tn
-- http://fortune.com/2016/10/06/bloom-energy-ipo/

cnb . cx
-- https://www.cnbc.com/2017/05/16/bloom-energy-2017-disruptor-50.html

delonline . us
-- http://www.delawareonline.com/story/news/local/2015/07/22/new-bloom-box/30475483/

on . ny . gov
-- https://www.nyserda.ny.gov/All-Programs/Programs/Clean-Energy-Standard/Renewable-Generators-and-Developers


The 10 long URLs become the following short URLs when posted in a comment. All links work when posted for the first time, but two of them display in abbreviated form followed by ellipsis. The actual short URLs for the two abbreviated links only show in the status bar of my browser when I float my mouse over the link.


SA comment

-- https://seekingalpha.com/c/19zadv (actual short URL)

-- https://seekingalpha.c... (but URL is displayed like this in the comment)

bit . ly

-- http://bit.ly/2ELc6GT

lat . ms
-- http://lat.ms/2xOGQGp

reut . rs
-- http://reut.rs/2BshInK

on . app . com
-- http://on.app.com/2y1j2vZ

read . bi
-- http://read.bi/2xhXwpZ

for . tn
-- http://for.tn/2vvYAkI

cnb . cx
-- http://cnb.cx/2w542OV

delonline . us
-- http://delonline.us/2ecQSbo (actual short URL)

-- http://delonline.us/2e... (but URL is displayed like this in the comment)

on . ny . gov
-- http://on.ny.gov/2vnRK0u


When clicking on "Edit Comment", all links are pulled into the edit box with their associated markup language as described in one of my earlier notes. The markup language shows each short URL twice, once with the href tag and again at the end for the display value. The href and display are the same for all links except the two with ellipsis. Those two have the actual short URL only in the href tag and show the abbreviated URL with ellipsis at the end of the markup.


Example of a non-abbreviated short URL with spaces added to suppress conversion:


< a rel="nofollow" target="_blank" href="http : // read . bi / 2xhXwpZ" >http : // read . bi / 2xhXwpZ 

< / a  >


Example of an abbreviated short URL with spaces added to suppress conversion:


< a rel="nofollow" target="_blank" href="http : // delonline . us / 2ecQSbo" > http : // delonline . us / 2e...

< / a >


So far so good. The href tag values for all links are fine, which is the actual definition for the hyperlink. The display values for the two abbreviated links should not be a problem either. But ending the edit and posting back reveals the problem. The two abbreviated links are now broken. All the other links are fine. Clicking "Edit Comment" again pulls the links back into the edit box. 


Inspecting the markup language of one of the broken links reveals the following:


< a rel="nofollow" target="_blank" href="http : // delonline . us / 2e" > http : // delonline . us / 2e< / a >...


The link display value has become the definition for the hyperlink in the href tag. The ellipsis is no longer part of the markup text and now appears outside the delimiters. Clearly the abbreviated short URLs are mishandled by "Edit Comment". That is the problem.

 

It should be noted that while I couldn't seem to render a short URL for tinyurl .com in my test here, that may have been a blessing. Looking at my old comments, I see that tinyurl is also displayed in abbreviated form and would have probably been broken too.


Hope this additional information helps.

Avatar
anonymous

This issue should now be fixed. Please let us know.


Thanks!